Start of port to v1.12.2

Discussion in 'Code' started by mikeprimm, Feb 17, 2018.

  1. @Dan_Prime Nice job on running down the issue - I saw the commit activity around that issue, which was why I tried the latest build (2796) AND the build before the change Lex made in September (2759), but without good results.

    I'll check the maven identifiers for the couple of new components that were needed (which, actually, included the maven-artifact JAR...), and adjust distribution.json appropriately.

    The legacy launcher, like most other launchers I've seen, doesn't rely on the --modListFile parameter, instead just putting mods in the default directory structure (under ./mods), which is why we're not seeing any issues there. If the Forge guys are slow on accepting the fix, we'll probably need to consider working around this.
     
    Dan_Prime likes this.
  2. I'm getting the impression that the requirement to match the Maven-Artifact field, at least for 1.12.2, isn't a concern - almost everything I've looked at (Optifine, BetterFoliage, JourneyMap, worldeditcuife) don't have it in their manifest. I'm pretty sure that field is only added if you go through the process of signing and publishing the artifact to a maven repo, which library writers tend to do but pretty much zero mod writers do.
     
  3. Dan_Prime

    Dan_Prime Sword of the Morning Coder

    Dynamic surroundings is the only issue I came across. They do declare an identifier, and it's different than the one we currently have declared. It's case sensitive as well.
     
  4. Dan_Prime

    Dan_Prime Sword of the Morning Coder

    mikeprimm likes this.
  5. OK - nice! Just to be clear: with 1.4.1, we should be good for updating to the newer forge, yes? I'll give it a spin - thanks for the quick response!

    Edit: Confirmed working - I've updated distribution.json, so we're all in sync with the current recommended Forge (2768).
     
    Last edited: Dec 31, 2018
  6. Dan_Prime

    Dan_Prime Sword of the Morning Coder

    @mikeprimm the affected forge versions will not work. Only the pre-rewrite version and any versions including my PR will work on the 1.12 client. Not working as of the update. Since we host forge forge we could just build it with the fix though.

    The compatibility fix just allows our launch code to use the old and rewritten versions of the modList format. The old version crashes if you put absolute: before an absolute path. The new version crashes if you don't.

    The argument itself isn't even being registered on the affected version, so there's no workaround other than not using the affected range of versions.

    I can build the jar and upload it to git, just note the file will not be signed.
     
    Last edited: Jan 1, 2019
  7. Really don't want to get into building a custom Forge for any reason.... if they don't accept the fix quickly, we can work around it without corrupting our ongoing ability to have a Forge supported by other modders (none of who will give us the time of day if we aren't working with an official Forge build).

    I was able to run successfully with your updated launcher, so I'm not sure I understand your statements - it's now working fine for 2768, and it wasn't before your launcher change.
     
  8. Dan_Prime

    Dan_Prime Sword of the Morning Coder

    The argument does not work in that build at all, how exactly is it working for you? Are you sure you're running the 1.12 client?

    [​IMG]

    As a side note, I'm not too concerned about the time for this to be merged. It's a very simple fix, literally 2 lines of code to review. It's just a matter of the devs bothering to look at the issues/PR tab. I have no problem @mentioning one of them after a week, but any sooner and I'm sure to get the good old "be patient" rant.
     
    Last edited: Jan 2, 2019
  9. Dan_Prime

    Dan_Prime Sword of the Morning Coder

    @mikeprimm the fix was merged, I updated the file on bitbucket.

    Also, I did try the old configuration on a new computer and it worked. I then tried it again on the other one and it still failed. Then I deleted the client files and it still failed.

    The new version works on both.
     
  10. Cool - pleasant surprise :) I definitely know you don't want to 'poke the bear' over on Forge: didn't know whether they're so tied up in trying to move 1.13.x forward that they were gonna be slow on looking at non-1.13 work!
     
    Dan_Prime likes this.
  11. OK - so, 1.12.2 test client and server are all up to date and ready for final testing! Please give it a look, so that we can prep for deploying it to production 'soon' :)
     
    geeberry and CashBanks like this.
  12. I’ll check it out soon, when I get home. A lab rat volunteer to help with perms testing would be helpful!
     
  13. Add me to the white-list and I'll take a look!
     
  14. Did some bug-testing with @CashBanks the other day.

    Everything seems fine and good to go, only noticed a couple very small issues:

    * All groups seem to have access to "/spawn #minecraft:the_end" -> this should be disabled for everyone.

    * No groups have perms for "/gm" -> this should be enabled for everyone.

    * One particular block (Dreadfort Skeleton Sconce Left/Right) seems to have a broken model/texture; I'm pretty sure this is just because we gave it a custom model file which was overridden by the JSON entry in the update. Is there any way to enter a line in the JSON preventing this from happening for a particular ID?
     
  15. That command also works in the 1.11 server and you can also use it to take you to the Nether (where Blazes, Skeletons etc still spawn).